[Freemint-list] TosWin2 fixes

[Miro Kropáček]

On 8 May 2017 at 05:19, Vincent Rivière <vincent.riviere at freesbee.fr> wrote:

> It only works if I manually open the console once after startup.
>
OK, your test case was a bit imprecise -- one has to set the option, save
settings, quit TW2 and then start it. It was a double bug and thanks to
this investigation I discovered a regression for which I can thank Helmut ;)

On 13 January 2017 at 09:20, Helmut Karlowski <helmut.karlowski at ish.de>
 wrote:

> I flew over it and wondered about:
>
> @@ -726,6 +727,14 @@ bool config_load(void)
>            buffer[strlen(buffer) - 1] = '\0';
>          parse_line(buffer);
>        }
> +
> +     if (gl_con_log)
> +     {
> +       bool on = gl_con_log;
> +       gl_con_log = FALSE;
> +       gl_con_log = log_console(on);
> +     }
> +
>
> Why do you set gl_con_log twice?


Of course this wasn't without meaning, the code is so ugly so using global
variables on different places (incl. log_console()) sometimes expects
certain state of things. Shouldn't have blindly trust him and keep it since
logging had worked before that.

Anyways, it's all fixed now, grab & test from the same place. Hopefully
it's final this time.

-- 
MiKRO / Mystic Bytes
http://mikro.atari.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.atariforge.org/pipermail/freemint-list/attachments/20170508/2cb96ed5/attachment.html