[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] [PATCH] ethernat.xif hangs the system if card isn't present



Vincent Rivière, 15.02.2013 10:37:10:

On 15/02/2013 09:28, David Gálvez wrote:
BTW: Shouldn't ethernat_200Hzint.s be renamed into ethernat_200Hzint.S?


I'm not really sure if this is necessary, as I understand only
assembler files that need to be preprocessed should have the capital S
extension.
I think that this file doesn't have anything that needs to be
preprocessed. Alan?

Please always use .S to allow preprocessing assembler files.
This allows to use #include, #ifdef (may be useful in the future, ColdFire compilation, etc.)
Also, that allows /* */ and // comments en assembler code.

It also makes it clear that the file is handwritten, not from a compiler or something.

So I'll rename it.

--
Helmut Karlowski