[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] [PATCH] ethernat.xif hangs the system if card isn't present



Thanks for the commit Helmut

2013/2/14 Helmut Karlowski <helmut.karlowski@ish.de>:
> David Gálvez, 14.02.2013 21:07:44:
>
>
>> "Replace the bus error exception handler before the probe operation to
>> avoid system freeze while loading the driver"
>
>
> Some white-space slipped through ..
>

Yes, I saw it. There was in the original code a part with too many
empty lines, I was tempted to remove them too, but I wanted to keep
the patch clean.
I guess you fell into temptation and removed some white line ;-)

> BTW: Shouldn't ethernat_200Hzint.s be renamed into ethernat_200Hzint.S?
>

I'm not really sure if this is necessary, as I understand only
assembler files that need to be preprocessed should have the capital S
extension.
I think that this file doesn't have anything that needs to be
preprocessed. Alan?

I forgot to remove some commented code, I have attached a new patch to
correct this.

Attachment: ethernat_xif_probe_20130215.diff
Description: Binary data