[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[MiNT] Network sockets don't work with new 1.18.current



Hi all,

I found today that network doesn't work with kernel 1.18 compiled from
the trunk.
Module inet4.xdd isn't loaded.

Before the module is loaded there is a check for the correct kernel's version.

File /sys/sockets/main.c line 96, the minor version check must be
upgraded it to 18.

http://sparemint.org/cgi-bin/cvsweb/freemint/sys/sockets/main.c?rev=1.5&content-type=text/x-cvsweb-markup

I don't know why the check is done like that, it's very easy to forget
putting the correct version when the kernel version is bumped.

Wouldn't be better to do something like this?

if ((MINT_MAJOR == 0)
		|| ((MINT_MAJOR == 1) && ((MINT_MINOR < 15) || (MINT_KVERSION < 2)))
|| !so_register)

As is done in other modules, just check that version is newer than
1.15 and kerinfo version 2 or upper??