[Freemint-list] Annoying printvars target

[Vincent Rivière]

Hello.

After a long interruption, I'm back to FreeMiNT sources.

I have just noticed a new annoying thing:

commit c89a8906bc29d499d062102080f3ab24709d1c67
Author: Markus Fröschle <mfro at mubf.de>
Date:   Sat Jan 28 16:06:41 2017 +0100

     enable optional link against libcmini instead of mintlib

diff --git a/CONFIGVARS b/CONFIGVARS
...
+.PHONY: printvars tests
+printvars:
+       @$(foreach V,$(.VARIABLES), $(if $(filter-out environment% default 
automatic, $(origin $V)),$(warning $V=$($V))))

It is not a good idea to add a target in the CONFIGVARS files. This file is 
most likely included at the top of the makefiles. When you just type "make", 
by definition it builds the first target found. Usually, that first target 
is "all", so a simple "make" builds everything.
But with the introduction of that printvars target at that place, a simple 
"make" results in variables being printed on the screen, instead of the 
expected build.

I noticed that in the xaaes/src.km/gradient directory. I used to build the 
stuff there with a simple "make", it does not work anymore.

IMHO that printvars target should be moved elsewhere.

-- 
Vincent Rivière