Re: [MiNT] [PATCH] Fix 6888x detection + SFP004 support

[Alan Hourihane <alanh@fairlite.co.uk>]

Look great to me.

I'll get this committed.

Alan.

On 30/05/15 17:59, Miro Kropáček wrote:
> Hi,
>
> following the discussion from February on this and Hatari lists
> regarding the FPU detection I set a goal to fix this but I needed
> physical access to my MegaSTE + 68881 so it took some time.
>
> The basic problem was that FreeMiNT detection code has been checking
> for revision numbers and not stack frame sizes, what is the
> recommended procedure by Motorola.
>
> This patch's changes:
> - FPU detection code algorithm improvement
> - the check in the sig handler, it has been working only by chance
> - adds support for SFP-004 boards, i.e. my MegaSTE now correctly
> reports not only SFP-004 but also what kind of FPU is installed
>
> I'm not sure how context switching applies to SFP-004? I.e. whether
> we're supposed to save context here, too? I'd say we are but who
> knows. Anyway, it's quite a complex change and it requires two
> SFP-compatible/aware programs running at the same time under FreeMiNT
> to make a collision...
>
> Just for fun I tried some sysinfo tools, whether they notice the
> fixed/improved _FPU cookie:
>
> - Sysinfo 5.02 is confused by 0x00050000, while it reports
> "MC68881/SFP004" in the cookie list, it goes from "68000/68881" to
> "68000/???" in the machine info
>
> - SYSINFO 8.34 does notice, it goes from "SFP004 or compatible" to
> "68881 + SFP004"
>
> So I'd say it's good to go. I know it's only a minor improvement and
> very few people will appreciate it (=me ;-)) but it's the right thing
> to do! :)
>
> -- 
> MiKRO / Mystic Bytes
> http://mikro.atari.org