Re: [MiNT] Toolbar width inconsistency (bad rectangle list?)

[Peter Persson <pep.fishmoose@gmail.com>]

17 dec 2010 kl. 14.41 skrev Helmut Karlowski:

> Peter Persson wrote:
> 
>> The problem is still there. The object width and the width of the =
>> rectangle list is not the same.
> 
> The right border of the toolbar is overwritten by the window-border wich not intended.

This seems correct now! :)

> Wich should always be the case: The toolbar obtains the whole window-width.

Yes. The rectangle list and the wind_set() redraw method didn't match this in the earlier version. It does now, however!

> Maybe the bootlog-entries would help (try to catch the ones that are for your app).

I'll have a look at it, but thing seems (almost) correct now!

> I've changed it again to force the toolbar having the whole width. This was wrong in your version.
> 
> Hope we're talking about the same ;-)
> 
> I know only one program that uses the AES-toobar-feature (the Atari-toolbar-demo), which I
> used to fix toolbars in XaAES. So I think we are free to change things here.

If the functionality changes, there should be a new API for it. Toolbars are carved in stone since 1992. The exception is pure esteathic changes, naturally. But since we're at it - the API could be extended to allow an additional toolbar in the bottom part of the window, or along the left/right sides of the window.

With this (and the last) version, a bug is introduced. It's triggered when using the wind_set() method to redraw the toolbar (XaAES-specific; the other way is to use the rectangle list). It breaks the vertical slider, and it seems it gets worse each time the slider and/or the toolbar is redrawn. This does not happen when using the legacy way to redraw the toolbar. It also didn't happen in the earlier versions. So whatever you changed related to the vertical slider, change it back :)

-- PeP