Re: [MiNT] mintlib rpm fix

[Alan Hourihane <alanh@fairlite.co.uk>]

On Wed, 2010-01-20 at 20:57 +0100, Miro Kropacek wrote:
> Before I made new patch:
> 
> 1. math.h wasn't removed! it's still there and I don't know how to
> delete it (include in patch file)

math.h shouldn't be deleted from mintlib as parts of mintlib use code
from it. We just shouldn't install mintlibs version, as the libm would
provide it.

> 2. some files reference this file, I corrected it (#include "math.h"
> -> <math.h>) BUT: there's -nostdinc flag in CFLAGS ! So what's the
> correct solution then? ln -s /usr/include/math.h math.h ?

Not required. Install fdlibm or pml as they should provide math.h.

> 3. It's better remove that check for NEWS file? Because I don't know
> if someone is ever going to update it.

A patch to update the NEWS file is recommended.

> 2010/1/20 Alan Hourihane <alanh@fairlite.co.uk>
>         On Wed, 2010-01-20 at 00:36 +0100, Vincent Rivière wrote:
>         > Miro Kropacek wrote:
>         > > I tried to compile my own RPM of mintlib 0.59 (as there's
>         no public
>         > > release yet) and I found out a lot of things is broken for
>         0.59 when
>         > > using files from CVS and old 2.95 gcc... I fixed this:
>         >
>         > You should not add math.h.
>         > Alan has explicitly removed it (will be provided by some
>         libm).
>         
>         
>         Correct. fdlibm or pml will provide this.
>         
>         Alan.
>         
>         
>         
> 
> 
> 
> -- 
> MiKRO / Mystic Bytes
> http://mikro.atari.org