[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] Patch: Deadkey support]



On Wed, 2010-01-06 at 08:21 +0100, Jo Even Skarstein wrote:
> --------------------------------------------------
> From: "Alan Hourihane" <alanh@fairlite.co.uk>
> Sent: Wednesday, January 06, 2010 12:07 AM
> To: "Jo Even Skarstein" <joska@online.no>
> Cc: <mint@lists.fishpool.fi>
> Subject: Re: [MiNT] Patch: Deadkey support]
> 
> >> - kbuf = kmalloc(size+1); /* Append a zero (if the table is missing the 
> >> altgr part) */
> >> + kbuf = kmalloc(size+2); /* Append a zero (if the table is missing the 
> >> altgr part) */
> >
> > Jo,
> >
> > I see that it's now +2 but the comment isn't updated. Can you fix that
> > in your patch ?
> 
> Not for a while :-( My Milan is currently not working (nothing serious 
> though, but I don't have time to fix it yet) so I don't have access to the 
> sources. The '+2' is there because there now might be two tables missing 
> from the file (AltGr and deadkeys), and not just one (AltGr) as before. If 
> this is an issue the patch will have to wait until I've repaired the Milan.

That's good enough. I'll update and fix. I'll test on my setup here this
week and commit.

Thanks,

Alan.